Collaborative Editing criterions and sort clauses #2903

mnocon · 2025-09-17T08:52:48Z

No description provided.

github-actions · 2025-09-17T09:02:04Z

Preview of modified files

Preview of modified Markdown:

github-actions · 2025-10-14T11:11:40Z

code_samples/ change report

Before (on target branch) After (in current PR)


code_samples/collaboration/src/Query/Search.php


code_samples/collaboration/src/Query/Search.php

docs/search/collaboration_search_reference/collaboration_criteria.md@47:```php hl_lines="11-16"
docs/search/collaboration_search_reference/collaboration_criteria.md@48:[[= include_file('code_samples/collaboration/src/Query/Search.php') =]]
docs/search/collaboration_search_reference/collaboration_criteria.md@49:```

001⫶<?php
002⫶
003⫶declare(strict_types=1);
004⫶
005⫶use Ibexa\Contracts\Collaboration\Session\Query\Criterion;
006⫶use Ibexa\Contracts\Collaboration\Session\Query\SortClause;
007⫶use Ibexa\Contracts\Collaboration\Session\SessionQuery;
008⫶
009⫶$now = new DateTimeImmutable();
010⫶
011❇️$query = new SessionQuery(
012❇️    new Criterion\LogicalAnd([
013❇️        new Criterion\IsActive(),
014❇️        new Criterion\Type(‘content’),
015❇️        new Criterion\CreatedAt($now, Criterion\CreatedAt::OPERATOR_LTE),
016❇️    ]),
017⫶    [
018⫶        new SortClause\CreatedAt(SortClause\CreatedAt::SORT_DESC),
019⫶    ]
020⫶);
021⫶
022⫶/** @var \Ibexa\Contracts\Collaboration\SessionServiceInterface $sessionService */
023⫶$results = $sessionService->findSessions($query);

docs/search/collaboration_search_reference/collaboration_sort_clauses.md@34:```php hl_lines="16-18"
docs/search/collaboration_search_reference/collaboration_sort_clauses.md@35:[[= include_file('code_samples/collaboration/src/Query/Search.php') =]]
docs/search/collaboration_search_reference/collaboration_sort_clauses.md@36:```

001⫶<?php
002⫶
003⫶declare(strict_types=1);
004⫶
005⫶use Ibexa\Contracts\Collaboration\Session\Query\Criterion;
006⫶use Ibexa\Contracts\Collaboration\Session\Query\SortClause;
007⫶use Ibexa\Contracts\Collaboration\Session\SessionQuery;
008⫶
009⫶$now = new DateTimeImmutable();
010⫶
011⫶$query = new SessionQuery(
012⫶    new Criterion\LogicalAnd([
013⫶        new Criterion\IsActive(),
014⫶        new Criterion\Type(‘content’),
015⫶        new Criterion\CreatedAt($now, Criterion\CreatedAt::OPERATOR_LTE),
016❇️    ]),
017❇️    [
018❇️        new SortClause\CreatedAt(SortClause\CreatedAt::SORT_DESC),
019⫶    ]
020⫶);
021⫶
022⫶/** @var \Ibexa\Contracts\Collaboration\SessionServiceInterface $sessionService */
023⫶$results = $sessionService->findSessions($query);

Download colorized diff

ciastektk

Remove all Criterion suffix from criteria name

ciastektk · 2025-10-14T12:32:34Z

docs/search/collaboration_search_reference/collaboration_criteria.md

+
+| Criterion | Description |
+|---|---|
+| [CreatedAtCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) | Find invitations based on the date they were created |


Suggested change

| [CreatedAtCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) | Find invitations based on the date they were created |

| [CreatedAt](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) | Find invitations based on the date they were created |

ciastektk · 2025-10-14T12:32:52Z

docs/search/collaboration_search_reference/collaboration_criteria.md

+| Criterion | Description |
+|---|---|
+| [CreatedAtCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) | Find invitations based on the date they were created |
+| [IdCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) | Find invitations with given invitation ID |


Suggested change

| [IdCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) | Find invitations with given invitation ID |

| [Id](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) | Find invitations with given invitation ID |

ciastektk · 2025-10-14T12:33:02Z

docs/search/collaboration_search_reference/collaboration_criteria.md

+|---|---|
+| [CreatedAtCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) | Find invitations based on the date they were created |
+| [IdCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) | Find invitations with given invitation ID |
+| [LogicalAndCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) | Composite criterion to group multiple invitations using the AND condition |


Suggested change

| [LogicalAndCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) | Composite criterion to group multiple invitations using the AND condition |

| [LogicalAnd](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) | Composite criterion to group multiple invitations using the AND condition |

ciastektk · 2025-10-14T12:33:14Z

docs/search/collaboration_search_reference/collaboration_criteria.md

+| [CreatedAtCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) | Find invitations based on the date they were created |
+| [IdCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) | Find invitations with given invitation ID |
+| [LogicalAndCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) | Composite criterion to group multiple invitations using the AND condition |
+| [LogicalOrCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalOr.html) | Composite criterion to group multiple invitations using the OR condition |


Suggested change

| [LogicalOrCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalOr.html) | Composite criterion to group multiple invitations using the OR condition |

| [LogicalOr](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalOr.html) | Composite criterion to group multiple invitations using the OR condition |

ciastektk · 2025-10-14T12:33:24Z

docs/search/collaboration_search_reference/collaboration_criteria.md

+| [IdCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) | Find invitations with given invitation ID |
+| [LogicalAndCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) | Composite criterion to group multiple invitations using the AND condition |
+| [LogicalOrCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalOr.html) | Composite criterion to group multiple invitations using the OR condition |
+| [SenderCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Sender.html) | Find invitations by invitation sender |


Suggested change

| [SenderCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Sender.html) | Find invitations by invitation sender |

| [Sender](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Sender.html) | Find invitations by invitation sender |

ciastektk · 2025-10-14T12:34:53Z

docs/search/collaboration_search_reference/collaboration_criteria.md

+| [LogicalAndCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) | Composite criterion to group multiple invitations using the AND condition |
+| [LogicalOrCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalOr.html) | Composite criterion to group multiple invitations using the OR condition |
+| [SenderCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Sender.html) | Find invitations by invitation sender |
+| [SessionCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Session.html) | Find invitations by collaboration session |


Suggested change

| [SessionCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Session.html) | Find invitations by collaboration session |

| [Session](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Session.html) | Find invitations by collaboration session |

Collaborative Editing criterions and sort clauses

7d21645

mnocon force-pushed the IBX-9737-criterions branch from 81df162 to 7d21645 Compare September 17, 2025 08:54

julitafalcondusza and others added 8 commits September 18, 2025 13:40

fixes after review

bc316f8

criterions and sort clauses moved to condensed pages

d8d2fe4

conflict resolved

98fedc9

composer, fixes

e99b223

code fixes

0024021

PHP & JS CS Fixes

ac36d01

fix

e2b6abd

fix

295099c

julitafalcondusza requested a review from ciastektk October 14, 2025 10:47

julitafalcondusza added the Needs DEV review label Oct 14, 2025

api links fixed

a17ef6f

ciastektk requested changes Oct 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Collaborative Editing criterions and sort clauses #2903

Collaborative Editing criterions and sort clauses #2903

mnocon commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

ciastektk left a comment

Uh oh!

ciastektk Oct 14, 2025

Uh oh!

ciastektk Oct 14, 2025

Uh oh!

ciastektk Oct 14, 2025

Uh oh!

ciastektk Oct 14, 2025

Uh oh!

ciastektk Oct 14, 2025

Uh oh!

ciastektk Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	\| [CreatedAtCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) \| Find invitations based on the date they were created \|
	\| [CreatedAt](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-CreatedAt.html) \| Find invitations based on the date they were created \|

	\| [IdCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) \| Find invitations with given invitation ID \|
	\| [Id](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Id.html) \| Find invitations with given invitation ID \|

	\| [LogicalAndCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) \| Composite criterion to group multiple invitations using the AND condition \|
	\| [LogicalAnd](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalAnd.html) \| Composite criterion to group multiple invitations using the AND condition \|

	\| [LogicalOrCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalOr.html) \| Composite criterion to group multiple invitations using the OR condition \|
	\| [LogicalOr](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-LogicalOr.html) \| Composite criterion to group multiple invitations using the OR condition \|

	\| [SenderCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Sender.html) \| Find invitations by invitation sender \|
	\| [Sender](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Sender.html) \| Find invitations by invitation sender \|

	\| [SessionCriterion](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Session.html) \| Find invitations by collaboration session \|
	\| [Session](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Collaboration-Invitation-Query-Criterion-Session.html) \| Find invitations by collaboration session \|

Collaborative Editing criterions and sort clauses #2903

Are you sure you want to change the base?

Collaborative Editing criterions and sort clauses #2903

Conversation

mnocon commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview of modified files

Uh oh!

github-actions bot commented Oct 14, 2025

code_samples/ change report

Uh oh!

ciastektk left a comment

Choose a reason for hiding this comment

Uh oh!

ciastektk Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

ciastektk Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

ciastektk Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

ciastektk Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

ciastektk Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

ciastektk Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 17, 2025 •

edited

Loading